Merged
Conversation
Also se: dotnet/msbuild#6494
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ladipro
approved these changes
May 27, 2021
| internal class MSBuildForwardingAppWithoutLogging | ||
| { | ||
| private static readonly bool AlwaysExecuteMSBuildOutOfProc = Env.GetEnvironmentVariableAsBool("DOTNET_CLI_RUN_MSBUILD_OUTOFPROC"); | ||
| private static readonly bool DoNotUseMSBUILDNOINPROCNODE = Env.GetEnvironmentVariableAsBool("DOTNET_CLI_DO_NOT_USE_MSBUILDNOINPROCNODE"); |
Member
There was a problem hiding this comment.
nit: Maybe remove the double negation: DOTNET_CLI_USE_MSBUILD_INPROC_NODE ?
Member
Author
There was a problem hiding this comment.
I was trying to keep name same as is the MSBUILD escape hatch toi avoid confusion between your OUTOFPROC and mine NOINPROC. People might get impression that OUTOFPROC == NOINPROC and get confused why we have two escapes for same thing. Ithough about DOTNET_CLI_DONT_USE_MSBUILD_SERVER_V1 but I believe it is confusing for anyone without knowledge of msbuild server background....
dsplaisted
added a commit
that referenced
this pull request
Jun 4, 2021
This reverts commit c0e7d2f.
rokonec
pushed a commit
that referenced
this pull request
Jun 4, 2021
rokonec
added a commit
that referenced
this pull request
Jun 14, 2021
Merged
ViktorHofer
pushed a commit
that referenced
this pull request
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve inner loop experience of building small project fast in scenarios:
dotnet new console
dotnet build/run
We force MSBuild to always use external reusable nodes/processes to build projects.
Measured improvement: #6467
Implementation:
Modify SDK to set MSBUILDNOINPROCNODE = 1
Implement escape hatches DOTNET_DO_NOT_USE_MSBUILDNOINPROCNODE = 1
Also see: dotnet/msbuild#6494